Skip to content

Pin importlib-metadata version for celery tests #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Oct 5, 2022

Description

Fixes #1371

The importlib-metadata released a new 5.0 with breaking changes last week and it's breaking the workflows. The end user decides which version of celery and importlib-metadata to use so we only pin the version in tests until we this issue is fixed upstream.

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 5, 2022
@srikanthccv srikanthccv changed the title Pin importlib-metadata version Pin importlib-metadata version for celery tests Oct 5, 2022
@srikanthccv srikanthccv marked this pull request as ready for review October 5, 2022 11:20
@srikanthccv srikanthccv requested a review from a team October 5, 2022 11:20
@srikanthccv srikanthccv merged commit 93b8398 into open-telemetry:main Oct 5, 2022
@srikanthccv srikanthccv deleted the fix-import-error-celery branch October 5, 2022 20:21
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-instrumentation-celery failing and blocking PRs
2 participants